RocketChat / RocketChat/Rocket.Chat

Unable to view Contact Chat History as livechat manager

Open
#19,231 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: roles / permissions subj: livechat
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Unable to view Contact Chat History as livechat manager

Steps to reproduce:

1. Open livechat from client
2. Assign user livechat manager role
3. Open Contact chat history
4. Select an older chat from list

Expected behavior:
Able to view chat history

Actual behavior:
If the user has role admin only the contact chat history is available but if it is assigned or also assigned the livechat manager role we are forbidden from seeing the page

Server Setup Information:

Version of Rocket.Chat Server: 3.6.0/3.6.1/3.6.2
Operating System: Debian 9
Deployment Method: tar
Number of Running Instances: 1
NodeJS Version: 12.16.1
MongoDB Version: 4.0.20

Client Setup Information

Desktop App or Browser Version: Google Chrome 85 and Firefox 80
Operating System: Debian 9 and Windows 10

Additional context
Fiddling with the permissions did not solve the problem, there seems to be an issue with the livechat manager role as if it is assigned all the permissions from the admin role it still doesn't work as expected

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by assigning the livechat manager role and opening an older entry in Contact chat history. Trace the permission checks involved in that page and compare them with the admin-only behavior described here. Done means a livechat manager can view older contact chats without being granted admin access, with a regression test covering the role.

Written by the indexing model from the issue text.

Assessment

Tech stack
debian, mongodb, nodejs
Domain
authorization, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.