RocketChat / RocketChat/Rocket.Chat

Disable update banner when done

Open
#19,086 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description

When upgrading, the banner to notify the new-version is still here

Steps to reproduce
  1. On a self installed instance
  2. Install a version with docker compose
  3. Wait for a new one to be notified
  4. Upgrade it
  5. The banner say there is a new version is still available
Expected behavior

Disable the banner at all for a specific account or for the instance because it's already notified in the specific rocket channel bot

OR

Hide the banner after upgrading because it's no more relevant

Actual behavior

I have to acknowledge the banner even if it's done

Server Setup Information
  • Version of Rocket.Chat Server: 3.6.4 to 3.7.0 this morning (CEST)
  • Operating System:
    Linux 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
 chat:
    image: rocketchat/rocket.chat:latest
    command: >
      bash -c
        "for i in `seq 1 30`; do
          node main.js &&
          s=$$? && break || s=$$?;
          echo \"Tried $$i times. Waiting 5 secs...\";
          sleep 5;
        done; (exit $$s)"
    restart: unless-stopped
    depends_on:
      - mongo
    volumes:
      - /***:/app/uploads
    environment:
      - PORT=3000
      - ROOT_URL=***
      - MONGO_URL=***
      - MONGO_OPLOG_URL=mongodb://***/local
  • Deployment Method: docker-compose
  • Number of Running Instances: 1
  • DB Replicaset Oplog: ??
  • NodeJS Version:
  • MongoDB Version: docker mongo:4.0
Client Setup Information
  • Browser Version: 3.6.4
  • Operating System: Manjaro

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are identified in the issue. Start by reproducing the upgrade flow with the reported Docker Compose setup and trace where the new-version banner is acknowledged or dismissed; done means the banner no longer remains after the upgrade.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker-compose, mongodb, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.