RocketChat / RocketChat/Rocket.Chat

Thread message notification does not disappear

Open
#19,077 17 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux hacktoberfest
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Once a thread message is appearing, I need to click on it in order to remove the blue notification picture. There is no other way to hide this notification.. In previous releases pressing ESC key removed all notifications from the current channel.
Now, at least under Rocketchat release 3.6.1 there is no other way to clean this notification.

Please note that I am using the following feature :
"Show thread messages in the main thread". Therefore, I am always able to see this "hidden" messages.

Steps to reproduce:
  1. ask someone to reply to a message in a "thread"
  2. try to remove this annoying notification either by opening this channel or by pressing ESC in this channel
Expected behavior:

as soon as I get to read this message, the notification should desapear.
Alright, hard to define. Let's make it simple: hitting the ESC key should clear all current channel notifications

Actual behavior:

This blue notificatiion asside the channel name stay. It only disappear when I click on the actual "new" message

Server Setup Information:
  • Version of Rocket.Chat Server: 3.6.1
  • Operating System:
  • Deployment Method:
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Client Setup Information
  • Desktop App or Browser Version: Firefox 78.0.2
  • Operating System: Fedora 33
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named in the report. Start by reproducing the thread notification behavior in Rocket.Chat 3.6.1 with “Show thread messages in the main thread” enabled, then inspect the channel notification and ESC-key handling entry points. Done means the blue notification can be cleared as described after reading the message or pressing ESC.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.