RocketChat / RocketChat/Rocket.Chat

Reply in thread does not work anymore in password-protected channels

Open
#19,068 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When trying to reply in a thread in a password-protected channel, there is a prompt for the channel password instead of the message input box. The prompt does not accept the correct password though, so there is no chance to reply in a thread in password-protected channels.

Steps to reproduce:

In a password-protected channel, hit "reply in a thread" on some message in the channel.

Expected behavior:

Ability to send a reply in thread.

Actual behavior:

Non-functional password prompt.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.4.3
Additional context
  • My first thought is that this might have been introduced with #17416, but I did not look into the code deep enough to recognize if it was and/or point to a specific piece of code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or code entry points are named. Reproduce the thread-reply flow in a password-protected channel and trace where the password prompt replaces the message input; done means a valid password allows the thread reply to be composed and sent.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.