RocketChat / RocketChat/Rocket.Chat

Manual User Approval by an admin should not be necessary for LDAP sync and users added by the admin

Open
#19,015 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

area: authentication
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When manual approval by an Admin is activated:

  • Users added from a secure authentication source (LDAP) should be automatically approved

  • Users added by an Admin in the settings should also be automatically approved. There is no need for this second step for the admin in this case

Steps to reproduce:
  1. Sync an existing user from LDAP

  2. The user still needs manual approval from an Admin

  3. Add an user as Admin in the config panel

  4. You still need to approve the user in a second step.

Expected behavior:

In both scenarios users should be approved automatically.

Actual behavior:

Users are not approved and can't login until the admin manually approves them.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.6.2
  • Operating System: Ubuntu Server 20.04
  • Deployment Method: Manual (tar)
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v12.14.0
  • MongoDB Version: 4.0.20
Client Setup Information

Issue is client independent

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the LDAP synchronization flow and the admin user-creation flow described in the issue, then follow where manual approval is assigned. Done means users from LDAP and users added by an administrator are approved automatically and can log in without a second approval step.

Written by the indexing model from the issue text.

Assessment

Domain
authentication, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.