RocketChat / RocketChat/Rocket.Chat
loadMissedMessages fails on a fresh server
Open
@gabrieleiro is already working on this.
Since Nov 13, 2020.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
After creating a fresh server without any users in it, the loadMissesMessage function fails because there are no registered users.
Steps to reproduce:
- git clone
- meteor npm install, meteor npm start
- error
Expected behavior:
No error
Actual behavior:
I20200915-15:35:11.984(-4)? Exception while invoking method loadMissedMessages Error: Invalid user [error-invalid-user]
I20200915-15:35:11.985(-4)? at MethodInvocation.loadMissedMessages (server/methods/loadMissedMessages.js:13:10)
I20200915-15:35:11.985(-4)? at MethodInvocation.methodsMap.<computed> (app/lib/server/lib/debug.js:67:34)
I20200915-15:35:11.985(-4)? at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12)
I20200915-15:35:11.985(-4)? at packages/ddp-server/livedata_server.js:1689:15
I20200915-15:35:11.985(-4)? at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
I20200915-15:35:11.985(-4)? at packages/ddp-server/livedata_server.js:1687:36
I20200915-15:35:11.986(-4)? at new Promise (<anonymous>)
I20200915-15:35:11.986(-4)? at Server.applyAsync (packages/ddp-server/livedata_server.js:1686:12)
I20200915-15:35:11.986(-4)? at Server.apply (packages/ddp-server/livedata_server.js:1625:26)
I20200915-15:35:11.986(-4)? at Server.call (packages/ddp-server/livedata_server.js:1607:17)
I20200915-15:35:11.986(-4)? at Object.post (app/api/server/v1/misc.js:262:26)
I20200915-15:35:11.986(-4)? at app/api/server/api.js:394:82
I20200915-15:35:11.986(-4)? at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
I20200915-15:35:11.986(-4)? at Object._internalRouteActionHandler [as action] (app/api/server/api.js:394:39)
I20200915-15:35:11.986(-4)? at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32)
I20200915-15:35:11.986(-4)? at packages/nimble_restivus/lib/route.coffee:59:33
I20200915-15:35:11.986(-4)? at packages/simple_json-routes.js:98:9
I20200915-15:35:11.987(-4)? => awaited here:
I20200915-15:35:11.987(-4)? at Promise.await (/Users/wreiske/.meteor/packages/promise/.0.11.2.1ixw4hn.8uhlk++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/promise_server.js:60:12)
I20200915-15:35:11.987(-4)? at Server.apply (packages/ddp-server/livedata_server.js:1638:22)
I20200915-15:35:11.987(-4)? at Server.call (packages/ddp-server/livedata_server.js:1607:17)
I20200915-15:35:11.987(-4)? at Object.post (app/api/server/v1/misc.js:262:26)
I20200915-15:35:11.987(-4)? at app/api/server/api.js:394:82
I20200915-15:35:11.987(-4)? at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
I20200915-15:35:11.987(-4)? at Object._internalRouteActionHandler [as action] (app/api/server/api.js:394:39)
I20200915-15:35:11.987(-4)? at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32)
I20200915-15:35:11.987(-4)? at packages/nimble_restivus/lib/route.coffee:59:33
I20200915-15:35:11.987(-4)? at packages/simple_json-routes.js:98:9
Server Setup Information:
- Version of Rocket.Chat Server: 3.7.0-develop
- Operating System: macOS
- Deployment Method: git clone
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.