RocketChat / RocketChat/Rocket.Chat

Node crash exporting messages with unset SMTP server

Open
#18,911 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Node app crash when I try to export messages from a channel and the SMTP outgoing server is not configured.

Steps to reproduce:
  1. Go to any channel
  2. Clic on Export Messages
  3. Select method: Export as file
  4. Clic on Export button
Expected behavior:

A file download process should start.

Actual behavior:

Node app crash.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.6.0
  • Operating System: CentOS 7
  • Deployment Method: Manual
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.14.0
  • MongoDB Version: 4.0.20
Client Setup Information
  • Desktop App or Browser Version: 2.17.11
  • Operating System: Ubuntu
Workarround:

After configure the SMTP outgoing server the problem is resolved. Although, the file is sent by email instead of being downloaded.

Relevant logs:

No logs are produced when this happens.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the channel export flow with the SMTP outgoing server unset, then trace the server-side export path and the handling of the file-export method. Done means exporting as a file no longer crashes the Node app and starts a file download without requiring SMTP configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.