RocketChat / RocketChat/Rocket.Chat

Disabling Push Gateway should not require register server & accept privacy terms

Open
#18,893 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Disabling Push Gateway should not require register server & accept privacy terms

Steps to reproduce:
  1. Install Rocket.Chat and do not register server
  2. Go to Administration > Push

Second issue:

  1. Even after register server & accept privacy terms

  2. Set Enable Gateway to unchecked

    image

  3. Click Save changes -> sometimes "Enable gateway" is immediately checked again

  4. Refresh browser

  5. Rocket.Chat displays "Cloud registration is still pending" then "Enable gateway" is checked again.

Expected behavior:

Disabling Gateway should be possible, which will enable GCM Keys etc. to be set.

Actual behavior:

Gateway is "checked" but can't be disabled. GCM Keys etc. cannot be set.

image

Second issue:

Rocket.Chat displays "Cloud registration is still pending" then "Enable gateway" is checked again.

Cloud registration is still pending
Mobile notifications will not work until the registration is finished. Learn more

Server Setup Information:
  • Version of Rocket.Chat Server: 3.6.1
  • Operating System: Docker
  • Deployment Method: Docker or AWS Fargate
  • Number of Running Instances: 1
  • DB Replicaset Oplog: local
  • NodeJS Version: 12
  • MongoDB Version: 4.0
Client Setup Information
  • Desktop App or Browser Version: Chrome
  • Operating System: Ubuntu 20.04.1
Additional context

MongoDB collection rocketchat_settings seems to confirm the value is already false, but for some reason Admin UI insists it's checked.

image

Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Administration > Push and reproduce the behavior with an unregistered server, then after registration with Enable Gateway unchecked. Trace the setting and cloud-registration state from the admin UI through save and refresh; done means the gateway can remain disabled and GCM keys can be configured without requiring registration or privacy-term acceptance.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
full-stack
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.