RocketChat / RocketChat/Rocket.Chat

Discussions stay forever in the side tab-panel after removing, if you pin their start notification.

Open
#18,863 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Pinned notifications about a started discussion make this discussion stay forever in the side "Discussions" tab and duplicate itself there.

Steps to reproduce:
  1. Start a private channel (group).
  2. Send a new message to that channel.
  3. Begin a discussion about this message.
  4. Pin the notification about started discussion in the main channel.
  5. Delete the started discussion.
  6. Unpin the notification about started discussion.
  7. Open side "Discussions" tab.
Expected behavior:

After I delete the discussion, it should disappear from the "Discussions" side tab.

Actual behavior:

After I deleted the discussion and opened the "Discussions" side tab, I saw two live messages for the deleted discussion. And I cannot even remove these messages from there.
rocket_chat_bug

Server Setup Information:
  • Version of Rocket.Chat Server: It is open.rocket.chat public server.
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Client Setup Information
  • Desktop App or Browser Version: 2.17.11 Windows client and Browser client version (Chrome 85.0.4183.83 x64).
  • Operating System: Windows 7 x64 and Windows 10 x64.
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the seven steps in the Discussions side tab, using the pinned discussion notification as the trigger. Trace how deleting the discussion and unpinning its notification update that tab. Done means the deleted discussion is absent and no duplicate live messages remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.