RocketChat / RocketChat/Rocket.Chat

The api/v1/login returns a valida token/user_id without a password being passed

Open
#18,792 3 comments 0 reactions 1 assignee View on GitHub

@pierre-lehnen-rc is already working on this.

Since Sep 9, 2020.

area: authentication
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Calling the api api/v1/login in a LDAP enabled environment without pass a password, returns a valid token/user_id for the informed username.

Steps to reproduce:

Using any API Rest client, call the api/v1/login with the following payload

{ 
    "username":"<inform_any_username_here>", 
    "ldapPass":"",
    "ldap":true,
    "ldapOptions":{}
}
Expected behavior:

This API call should return a 401 Unauthorized code.

Actual behavior:

It returns a valid token/user_id which allows me to impersonate this user, and call another api, like chat.postMessage with the headers X-Auth-Token and X-User-ID.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.5.0
  • Operating System: Centos 7 x86_64
  • Deployment Method: AWS EC2
  • Number of Running Instances: 1 EC2 instances
  • DB Replicaset Oplog: N/A
  • NodeJS Version: The version required by de Rocket.Chat 3.5.0
  • MongoDB Version: 4.2
Client Setup Information
  • Desktop App or Browser Version: N/A
  • Operating System: N/A
Additional context

N/A

Relevant logs:

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.