RocketChat / RocketChat/Rocket.Chat

Invitation links show registration step when registration link is disabled

Open
#18,717 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux hacktoberfest triaged type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Currently, the registration link is disabled and it's available only via OAuth provider.

Via the normal login page https://chat.example.com it's not showing as expected, but when I send an invitation link to someone it appears.

Steps to reproduce:
  1. Add an OAuth provider
  2. Disable all the other authentication/registration methods
  3. Send an invitation link to someone
Expected behavior:

To see the login via oauth provider only, like the main login page:
Screen Shot 2020-08-28 at 16 46 51

Actual behavior:

I'm seeing the login and a registration link right below:
Screen Shot 2020-08-28 at 16 44 36

Server Setup Information:
  • Version of Rocket.Chat Server: 3.5.4
  • Operating System: Ubuntu 20.04
  • Deployment Method: docker-compose
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v12.16.1
  • MongoDB Version: 4.0.20
Client Setup Information
  • Desktop App or Browser Version: Google Chrome | 84.0.4147.135 (Official Build) (64-bit)
  • Operating System: Mac OS 10.15.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the invitation-link flow with an OAuth provider enabled and all other authentication or registration methods disabled, then compare it with the normal login page. Done means the invitation link offers only the OAuth login, without the registration link shown in the reported screenshots.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.