RocketChat / RocketChat/Rocket.Chat
Snap upgrade from 2.4.11 -> 3.x/stable loses 'Hide System Messages' setting
Open
Nobody has claimed this yet.
stale
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Snap upgrade from 2.4.11 -> 3.x/stable loses Hide System Messages settings
Steps to reproduce:
- Install 2.4.11 via snap latest/stable channel
- Set Admin -> Message -> Hide System Messages to Hide User Join and Hide User Leave messages
- Upgrade Rocketchat via snap to 3.x/stable
Expected behavior:
Hide System Message maintains Hide User Join and Hide User Leave messages settings
Actual behavior:
Channels will announce User Join and User Leave events
Admin -> Messages -> Hide System Messages shows 2 empty values (see screen shot)
Server Setup Information:
- Version of Rocket.Chat Server: 3.5.2
- Operating System: Ubuntu 18 LTS
- Deployment Method: snap
- Number of Running Instances: 1
- DB Replicaset Oplog: Enabled
- NodeJS Version: v12.16.1
- MongoDB Version: 3.6.14
Client Setup Information
- Desktop App or Browser Version: both
- Operating System: all
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or code entry points. Start by reproducing the upgrade from snap latest/stable 2.4.11 to 3.x/stable and inspect how the Hide System Messages settings are persisted and migrated; done means the Hide User Join and Hide User Leave values remain after upgrade.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100