seems to be a bug in activating users once they use registration page and email for activation is sent to admins

Description:

I setup a site where you can register to rocket.domain.ca/register/. Users can go there and create an account and an email for approval is sent to the admin. When the admin then goes into the app admin->users if you click on the pending user to approve the left side panel of admin goes blank.

I am able to get around this by going into admin->accounts->Registration and turn off "Manually Approve New Users". You can then go to admin->users click on the pending user and activate his account. I confirm he does get an email etc.

please note: The email the pending user gets says "user,
Your account was approved." This template I cannot find it anywhere to modify it. It would be nice to at least show the URL the user could click to login.

Steps to reproduce:

I am using Mac RC app and tried the browser in chrome and brave. Both just show blank when admin->accounts->Registration and turn off "Manually Approve New Users" is turned on. turn it off and you can activate the account. again though I can't find where to modify this template cause its a one liner and not very intuitive to a new user.

Expected behavior:

you should see the user and able to activate without having to turn off admin->accounts->Registration and turn off "Manually Approve New Users"

Actual behavior:

blank screen on the right side of admin when clicking on the user pending active from admin.

Server Setup Information:

• Version of Rocket.Chat Server:

Version	3.5.2
1.16.0
202
August 15, 2020 9:31 AM
December 26, 2019 3:32 PM
3 days, 6 hours, 41 minutes, 6 seconds
zY4v5BXtivttdoybP
22576
1
Enabled

• Operating System:
  Centos7
• Deployment Method: https://docs.rocket.chat/installation/manual-installation/centos
• Number of Running Instances: only one RC server on this
• DB Replicaset Oplog: I have no idea what you are talking about
• NodeJS Version: v12.18.3
• MongoDB Version: MongoDB server version: 4.0.19

Client Setup Information

• Desktop App or Browser Version: both on Mac
• Operating System: high sierra 10.13.6

Additional context

Relevant logs:

I actually looked at the logs while clicking away and nothing really reported. But here are some error logs

I20200818-15:48:53.566(-4) Exception while invoking method login Error: User is not activated [error-user-is-not-activated] at app/authentication/server/startup/index.js:327:9 at packages/callback-hook/hook.js:131:22 at packages/accounts-base/accounts_server.js:154:15 at Hook.each (packages/callback-hook/hook.js:109:15) at AccountsServer._validateLogin (packages/accounts-base/accounts_server.js:151:29) at AccountsServer._attemptLogin (packages/accounts-base/accounts_server.js:340:10) at MethodInvocation.methods.login (packages/accounts-base/accounts_server.js:522:23) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12) at packages/ddp-server/livedata_server.js:1689:15 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at packages/ddp-server/livedata_server.js:1687:36 at new Promise () at Server.applyAsync (packages/ddp-server/livedata_server.js:1686:12) at Server.apply (packages/ddp-server/livedata_server.js:1625:26) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9 => awaited here: at Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:60:12) at Server.apply (packages/ddp-server/livedata_server.js:1638:22) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9

I20200818-15:49:34.226(-4) Exception while invoking method verifyEmail Error: User is not activated [error-user-is-not-activated] at app/authentication/server/startup/index.js:327:9 at packages/callback-hook/hook.js:131:22 at packages/accounts-base/accounts_server.js:154:15 at Hook.each (packages/callback-hook/hook.js:109:15) at AccountsServer._validateLogin (packages/accounts-base/accounts_server.js:151:29) at AccountsServer._attemptLogin (packages/accounts-base/accounts_server.js:340:10) at AccountsServer._loginMethod (packages/accounts-base/accounts_server.js:372:17) at MethodInvocation.verifyEmail (packages/accounts-password/password_server.js:919:19) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12) at packages/ddp-server/livedata_server.js:1689:15 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at packages/ddp-server/livedata_server.js:1687:36 at new Promise () at Server.applyAsync (packages/ddp-server/livedata_server.js:1686:12) at Server.apply (packages/ddp-server/livedata_server.js:1625:26) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9 => awaited here: at Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:60:12) at Server.apply (packages/ddp-server/livedata_server.js:1638:22) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9

I20200818-15:49:51.711(-4) Exception while invoking method login Error: User is not activated [error-user-is-not-activated] at app/authentication/server/startup/index.js:327:9 at packages/callback-hook/hook.js:131:22 at packages/accounts-base/accounts_server.js:154:15 at Hook.each (packages/callback-hook/hook.js:109:15) at AccountsServer._validateLogin (packages/accounts-base/accounts_server.js:151:29) at AccountsServer._attemptLogin (packages/accounts-base/accounts_server.js:340:10) at MethodInvocation.methods.login (packages/accounts-base/accounts_server.js:522:23) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12) at packages/ddp-server/livedata_server.js:1689:15 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at packages/ddp-server/livedata_server.js:1687:36 at new Promise () at Server.applyAsync (packages/ddp-server/livedata_server.js:1686:12) at Server.apply (packages/ddp-server/livedata_server.js:1625:26) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9 => awaited here: at Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:60:12) at Server.apply (packages/ddp-server/livedata_server.js:1638:22) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9

I20200818-16:14:19.289(-4) Exception while invoking method autoTranslate.getSupportedLanguages Error: Auto-Translate is not allowed [error-action-not-allowed] at MethodInvocation.autoTranslate.getSupportedLanguages (app/autotranslate/server/methods/getSupportedLanguages.js:11:10) at MethodInvocation.methodsMap. (app/lib/server/lib/debug.js:67:34) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12) at packages/ddp-server/livedata_server.js:1689:15 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at packages/ddp-server/livedata_server.js:1687:36 at new Promise () at Server.applyAsync (packages/ddp-server/livedata_server.js:1686:12) at Server.apply (packages/ddp-server/livedata_server.js:1625:26) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9 => awaited here: at Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:60:12) at Server.apply (packages/ddp-server/livedata_server.js:1638:22) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9

I20200818-16:14:31.872(-4) Exception while invoking method login Error: User not found [403] at AccountsServer.Accounts._runLoginHandlers (app/lib/server/lib/loginErrorMessageOverride.js:10:18) at MethodInvocation.methods.login (packages/accounts-base/accounts_server.js:520:31) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12) at packages/ddp-server/livedata_server.js:1689:15 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at packages/ddp-server/livedata_server.js:1687:36 at new Promise () at Server.applyAsync (packages/ddp-server/livedata_server.js:1686:12) at Server.apply (packages/ddp-server/livedata_server.js:1625:26) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9 => awaited here: at Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:60:12) at Server.apply (packages/ddp-server/livedata_server.js:1638:22) at Server.call (packages/ddp-server/livedata_server.js:1607:17) at Object.post (app/api/server/v1/misc.js:262:26) at app/api/server/api.js:388:82 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js🔢12) at Object._internalRouteActionHandler [as action] (app/api/server/api.js:388:39) at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32) at packages/nimble_restivus/lib/route.coffee:59:33 at packages/simple_json-routes.js:98:9

Start by reproducing the blank admin user panel with manual approval enabled, then inspect the admin users flow and the authentication path referenced in app/authentication/server/startup/index.js. Use the reported login and verifyEmail errors to trace the behavior; done means an administrator can open and activate a pending user while approval remains enabled.