RocketChat / RocketChat/Rocket.Chat
Renaming custom emojis breaks image
Open
Nobody has claimed this yet.
area: ui/ux
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
After renaming an emoji the image is still visible in Administration but in chat only a little question mark appears.
Steps to reproduce:
- Go to 'Custom Emojis' in Administration
- Create new emoji with name 'foo'
- Write ':foo:' in chat -> Emoji shows
- Go to 'Custom Emojis' in Administration and change name to 'bar'
- Write ':bar:' in chat
Expected behavior:
Emoji shows
Actual behavior:
Little question mark placeholder shows
Additional context
If I upload the image again when renaming and then save the emoji it works as intended.
Server Setup Information:
- Version of Rocket.Chat Server: 3.5.0
- Operating System: linux
- Deployment Method: docker
- Number of Running Instances: 1
Client Setup Information
- Desktop App or Browser Version: Chrome 84
- Operating System: Arch Linux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the rename through Administration's Custom Emojis page, then check the resulting :bar: message in chat. Trace the custom emoji rename and image handling from the administration entry point through chat rendering. Done means a renamed emoji remains visible when used under its new name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100