RocketChat / RocketChat/Rocket.Chat
Some file types get rejected during upload despite being allowed in the settings
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Trying to upload .sketch files shows an error window despite all file types being allowed in the settings
Steps to reproduce:
- Upload .sketch file
Expected behavior:
The file to be uploaded successfully
Actual behavior:
Trying to upload .sketch files gives the following error window:
This is despite all file types being allowed in the backend:
Server Setup Information:
- Version of Rocket.Chat Server: 3.4.0
- Operating System: Docker
- Deployment Method: Docker
- Number of Running Instances: 1
- DB Replicaset Oplog: yes
- NodeJS Version:
- MongoDB Version:
Client Setup Information
- Desktop App or Browser Version: Chrome
- Operating System: OS X
Additional context
This definitely used to work before. We are not sure if it was introduced by the 3.4.0 release specifically, but must be a fairly new issue.
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the upload failure in Chrome with a .sketch file while all file types are allowed in the backend settings. Trace the client and server upload validation to find where this extension is rejected. Done means an allowed .sketch file uploads successfully without the error window.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100