RocketChat / RocketChat/Rocket.Chat
LDAP - ability to create private rooms from group/channel sync
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Currently, LDAP Group/Channel sync creates only channels. It is not possible for the synch to create private rooms.
For LDAP integration cases, this would be a good feature, as the LDAP Groups usually are "teams" withing a company, and those team usually should be synched to private rooms.
Steps to reproduce:
- Activate "Auto Sync LDAP Groups to Channels" option
- Map the group/channels on "LDAP Group Channel Map" field
- Run the LDAP Synch -> Only channels will be generated.
Expected behavior:
Possiblity to choose the behavior. Even better if you could add the channel type inside the JSON mapping.
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 3.4.0-develop
Relevant logs:
The type "c" is declared here:
https://github.com/RocketChat/Rocket.Chat/blob/ed1c213157ff57eda8a351be2aec8d6c036be716/app/ldap/server/sync.js#L283
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/ldap/server/sync.js around line 283, where the synced room type is declared, and trace how the LDAP Group Channel Map is processed. Define how the mapping selects private rooms instead of only channels, then verify that an LDAP sync creates the requested room type for mapped groups.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100