RocketChat / RocketChat/Rocket.Chat
[IMPROVEMENT] Enable navigating to a room from auth deep linking
Open
@pierre-lehnen-rc is already working on this.
Since Jul 7, 2020.
planned
triaged
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Use auth deep linking api and go to a specific room as in reactNative
https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/2115
Steps to reproduce:
- Go to auth deep link api with path="group/#{room_name}"
Expected behavior:
You will be auto login and go to the room specified in the path.
Actual behavior:
Go to the lobby(home page), no matter which path you pass.
Server Setup Information:
- Version of Rocket.Chat Server:
- Operating System:
- Deployment Method:
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version:
- MongoDB Version:
Client Setup Information
- Desktop App or Browser Version: both
- Operating System: macOS
Additional context
The inconsistency between the versions cause issues and different behaviour .
can be fix here https://github.com/RocketChat/Rocket.Chat/blob/develop/client/startup/loginViaQuery.js#L7
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.