RocketChat / RocketChat/Rocket.Chat

[Bug] No DM Notifications when both Desktop and Mobile Preferences is set to Mentions

Open
#17,844 12 comments 1 reaction 1 assignee View on GitHub

@gabrieleiro is already working on this.

Since Nov 4, 2020.

feat: notification
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

I already found some issue with Notification set to Mentions in #17689
But now we did all tests and can tell for sure, that there is a bug - No DM Notifications when both Desktop and Mobile Preferences is set to Mentions

Steps to reproduce:
  1. User1 set Show Desktop Notifications For to Mentions
  2. User1 set Push Mobile Notifications For to Mentions
  3. User2 write DM to User1
  4. User1 gets no notifications neither desktop or mobile
Expected behavior:

There should be notifications (both desktop and mobile, if desktop not online) on DM messages

Actual behavior:

Here is a problematic settings:
image

Here is a table (matrix) of all available and tested variants of types of chats and as a result - notifications.
image
If YES - there was notification
If NO - there wasn't notification
Filled in red - problem notifications. There should be notifications according to settings and other tests, but in fact - no notifications.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.1.1
  • Operating System: CentOS7
  • Deployment Method: docker
  • Number of Running Instances: 25
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.16.1
  • MongoDB Version: 4.0.17
Client Setup Information
  • Desktop App or Browser Version: 2.17.9 and Chrome 83
  • Operating System: Windows 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.