RocketChat / RocketChat/Rocket.Chat
Offline_Message_Use_DeepLink defaults to false
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
As of 3.1.1 this defaults to true, which means all links to direct messages go through go.rocket.chat as a deeplink proxy.
I personally find this to be the wrong default, it should be false as this is likely a breaking change for many of our setups. It's also kind of a privacy issue, as it means many people will now be sharing details of their user activity with the rocket chat community, which they may not have access to in their terms of service (We didn't and it was a bit of a headache to reverse this after deploying the update).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue identifies the Offline_Message_Use_DeepLink setting but names no files, tests, or entry points. Locate where this setting's default is defined, review existing coverage for direct-message links, and confirm that a fresh configuration uses false without breaking the surrounding link behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100