RocketChat / RocketChat/Rocket.Chat

Punctuation breaks user mention

Open
#17,336 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux type: improvement
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When tagging someone in a chat message within a public channel, if you include punctuation after the tag it breaks the tagging functionality.

Steps to reproduce:
  1. Message in a public channel while tagging a user in the channel.
  2. Include a period or other punctuation after the user tag.
  3. The tag is not active when sent to the channel
Expected behavior:

A tag should remain active even in the case when punctuation is included after it.

Actual behavior:
Screen Shot 2020-04-16 at 2 44 48 PM
Server Setup Information:

I'm just a lowly user of this server, so I'm not totally sure. The version where unread channels start appearing at the top of the channels list

  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method: docker
  • Number of Running Instances: 2 (prod/test)
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Client Setup Information
  • Desktop App or Browser Version: Desktop, but it's on both.
  • Operating System: Mac

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by tagging a user in a public-channel chat message and placing punctuation immediately after the tag, using both the desktop app and browser if possible. Trace the message mention handling from the chat composer or message rendering entry point; done means the tag remains active when followed by punctuation, with coverage for the reported punctuation cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.