RocketChat / RocketChat/Rocket.Chat

Welcome message not parsed when logging into Rocket.Chat

Open
#16,055 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When logging into Rocket.Chat, my welcome message that I customized in the administration layout screen appears, but above it the raw text Welcome <em>%s</em>. is inserted as is the %s is not processed and replaced.

Steps to reproduce:
  1. Login to Rocket.Chat
  2. Read the Welcome message that appears in the right pane
Expected behavior:

Welcome Jim

Actual behavior:

Welcome %s

Server Setup Information:
  • Version of Rocket.Chat Server: ? Don't know where to find this information
  • Version of Rocket.Chat API: 2.3.2
  • Operating System: CentOS Linux release 7.7.1908 (Core)
  • Deployment Method: https://rocket.chat/docs/installation/manual-installation/centos/
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v8.11.4
  • MongoDB Version: MongoDB shell version v4.0.14
Client Setup Information
  • Desktop App or Browser Version: Firefox 71 (does the same thing in the mobile app or the desktop app)
  • Operating System: Linux Mint LMDE
Additional context

N/A

Relevant logs:

Not sure if there are logs that I should be including or not, and if so what? It seems to be a parsing issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is identified in the issue. Reproduce the problem by logging in and checking the right-pane welcome message, then trace its rendering and verify that the customized message replaces the raw %s placeholder without adding the unprocessed text.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.