RocketChat / RocketChat/Rocket.Chat
Invite user to channel by name / email
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Should be able to invite users to a channel by name, not just username (input does not allow spaces).
Steps to reproduce:
- go to a channel
- click the Members List button (note: should really be "Member List" -- list already implies plurality)
- click the Invite Users button
- attempt to search for a user by name, e.g. "jim smith" -- space is not allowed; must search by username
Expected behavior:
Spaces should be allowed and search via name/username/email should work.
Actual behavior:
Spaces are not allowed and you must search specifically be username.
Server Setup Information:
- Version of Rocket.Chat Server: 3.4.2
- Operating System: RHEL7
- Deployment Method: Docker
- Number of Running Instances: 1
- DB Replicaset Oplog: enabled
- NodeJS Version: 12.16.1
- MongoDB Version: 4.0.9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the channel Members List and Invite Users flow described in the reproduction steps, then trace the search input and user lookup. Verify how spaces are handled and how users are matched by name, username, and email. Done means the invite search accepts names with spaces and returns matches for all three identifiers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100