RocketChat / RocketChat/Rocket.Chat

[BUG] Annoymous Read/Write can bypass permissions

Open
#14,942 0 comments 1 reaction 1 assignee View on GitHub

@ggazzo is already working on this.

Since Aug 15, 2019.

security triaged
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Annoymous Read/Write can bypass permissions

#10685 related

Steps to reproduce:
  1. Enable Anonymous Read and Anonymous Write

  2. Create a public channel with join code

  3. Remove preview channel permission for anonymous role

  4. Click this channel as anonymous user (still be able to preview the content)

  5. Enable Anonymous Read and Anonymous Write

  6. Delete all public rooms

  7. Registered user cannot sign-in because there is no button!

  8. Enable Anonymous Read and Anonymous Write

  9. Create a public channel

  10. Remove all permissions for guest and anonymous user

  11. Browse the website as anonymous user(you can still see all public channels. But if you click on one channel , click "join as anonymous", input anonymous name , you will find that you cannot join them or see any public channel )

Server Setup Information:
  • Version of Rocket.Chat Server: 1.2.1
  • Deployment Method:
  • Number of Running Instances: 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.