RocketChat / RocketChat/Rocket.Chat
Restricted user can not see all accessible other users in the Directory (no permission view-outside-room)
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Steps to reproduce:
- Remove the permission
view-outside-roomfrom the roleUser - Create a new group
TestGroup 1 - Create User A and add the user to the group just created
- Create User B and add the user to the group just created
- Login with User A and click on the search button to search for other users
Expected behavior:
Search result should contain User B, as he is in the same group as User A.
Actual behavior:
Only those users can be found, where at least once a discussion was started.
Server Setup Information:
- Version of Rocket.Chat Server: 1.1.3
- Operating System: Linux
- Deployment Method: Docker
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: 8.11.4
- MongoDB Version: 4.0.10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by removing view-outside-room, placing two users in the same group, and searching as User A. Trace the Directory search permission filtering and verify that User B appears without a prior discussion. Done means same-group users are returned while users outside the permitted scope remain excluded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100