RocketChat / RocketChat/Rocket.Chat

Wrong online users counter in big channels.

Open
#14,538 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Wrong online users counter in big channels. The online user counter counts only those users that are loaded to the list of users on this channel. If there are more than 100 online users on the channel, the conter will show “Showing: 100, Online: 100”. If you then click the "Show more" button, the counter value will change to "Showing: 200, Online: 200".

Steps to reproduce:
  1. Go to the big channel where you know that there more then 100 users online.
  2. Notice the counters values
  3. Click "Show more" button and notice the counters values again.
Expected behavior:

The correct online counter.

Actual behavior:

image
image

Server Setup Information:
  • Version of Rocket.Chat Server: 1.0.3
  • Operating System: Ubuntu 18.04
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: 1
  • NodeJS Version: v8.11.3
  • MongoDB Version: 3.4.20
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are identified in the issue. Reproduce the counter behavior in a channel with more than 100 online users, then trace the online-user count separately from pagination; done means the counter remains accurate before and after clicking “Show more”.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.