RocketChat / RocketChat/Rocket.Chat

Search users in channel not work correct

Open
#14,537 5 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

If there are many users in the channel (> 100) then the search does not work correctly. If the user is not present in the list of loaded users ("show more" button ), then he is not displayed in the search results.

Steps to reproduce:
  1. Go to big channel and open Members list
  2. Load a lot of users (1 or more click to "Show more" button) and notice some user name.
  3. Close the member list
  4. Open the member list again
  5. Type the noticed user name in search field
Expected behavior:

The user is displayed in the search result.

Actual behavior:

image
but user is there (after using show more button)
image

Server Setup Information:
  • Version of Rocket.Chat Server: 1.0.3
  • Operating System: Ubuntu 18.04
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: 1
  • NodeJS Version: v8.11.3
  • MongoDB Version: 3.4.20
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. First reproduce the member-list search in a channel with more than 100 users, then trace the client-side member list and search behavior; it is done when searching immediately finds a user who was not loaded through “Show more”.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.