RocketChat / RocketChat/Rocket.Chat
Blank Internal Hubot menu settings
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Steps to reproduce:
Admin > Settings > Internal Hubot
Expected behavior:
As I have disable Internal Hubot through the env var SETTINGS_HIDDEN=InternalHubot, I expect this entry not displayed.
Actual behavior:
Even if I use SETTINGS_HIDDEN=InternalHubot the entry appears in Settings.
Seems linked to #13522
Server Setup Information:
- Version of Rocket.Chat Server: 1.0.2
- Operating System: Linux
- Deployment Method: Docker
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: 8.11.4
- MongoDB Version: 4.0
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Admin > Settings > Internal Hubot and reproduce the behavior with SETTINGS_HIDDEN=InternalHubot in the Docker deployment described. Trace how this environment variable is applied to the settings entry; done means the Internal Hubot entry is absent when hidden while other settings remain available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100