RocketChat / RocketChat/Rocket.Chat

Bug with joining

Open
#14,221 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When a new user joins, it adds them to the default channels, which is normal. But if they change their username, their join message username link doesn't work anymore, freezing the sidebar.

Suggested Solution

Make the user tags (the clickable usernames) tied to user IDs, preventing username changes from breaking the user info page

Make the user details page (userinfo flex panel) error when it is unable to grab user details

Steps to reproduce:
  1. Join a channel
  2. Change your username
  3. Click on the "user joined channel" message's username
Expected behavior:

Not to freeze

Actual behavior:

Freezes user info flex panel

Server Setup Information:
  • Version of Rocket.Chat Server: 0.74.3
  • Operating System: CentOS 7
  • Deployment Method: Manual installation
  • Number of Running Instances: 3
  • DB Replicaset Oplog: Mongo?
  • NodeJS Version: 8.15.1
  • MongoDB Version: 3.4.20
Additional context
Relevant logs:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue through the channel join message and the userinfo flex panel after changing the user's username. Trace how the clickable username is resolved and how the panel handles missing user details; done means the link remains usable after the rename and the panel does not freeze when details cannot be retrieved.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.