RocketChat / RocketChat/Rocket.Chat

guest users shouldn't be added to default channels

Open
#13,970 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: authentication
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

A new Rocket.Chat user with 'guest' role joins the default channel(s).
Our 'guest' permissions are:

  • view-d-room
  • view-joined-room
  • view-p-room
    The guest can receive messages and invitations, but nothing else. So he is not able to see other users except users in the same channel he is invited to.
Steps to reproduce:
  1. Create new user with role 'guest'
  2. Login to Rocket.Chat
  3. Auto-Join default channel with all members and internal-information for not-guest
Expected behavior:

I would not expect a guest user to join default channels - or have a permission to deny it.

Actual behavior:

A guest user with minimal permission joins default channels.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.74.3
  • Operating System: Debian 9.8
  • Deployment Method: tar
  • Number of Running Instances: 3
  • DB Replicaset Oplog: yes
  • NodeJS Version: 8.11.4
  • MongoDB Version: 3.2.11
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source files or tests, so start by tracing guest-role handling during login and default-channel auto-join, using the reproduction steps as the first check. Done means guest users no longer join default channels while still retaining access to channels they are explicitly invited to, with regression coverage for the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.