RocketChat / RocketChat/Rocket.Chat
'Marked' markdown parser does not render usernames in GFM tables
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
The 'Marked' markdown parser does not render usernames in GFM tables
name | user
--- | ---
John Smith | @jsmith
Steps to reproduce:
Use a server that has 'Marked' selected as the Markdown parser and has 'GFM Tables' enabled.
Admin -> Messages -> Markdown:
Markdown_Parser: Marked
Markdown_Marked_GM: True
Markdown_Marked_Tables: True
Expected behavior:
The username should be highlighted and shown as the user name, and thus result in notifications to that user.
Actual behavior:
username is just rendered as plain text.
Server Setup Information:
- Version of Rocket.Chat Server: 0.74.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the Marked parser and GFM Tables enabled using the supplied table example. Trace how table cell content is parsed and how usernames trigger notifications; done means @jsmith is highlighted as a username and the user receives a notification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100