RocketChat / RocketChat/Rocket.Chat
Not all emails sent with @all
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When we use @all RC doesn't send all users an email.
Steps to reproduce:
- Post a message with @all
- Check outgoing email and see that not all users will receive an email
Expected behavior:
All users should receive an email when @all is used.
Actual behavior:
111 emails are sent out of 262 users.
Server Setup Information:
- Version of Rocket.Chat Server: 0.74.3
- Operating System: Linux x64
- Deployment Method: tar
- Number of Running Instances: 1
- DB Replicaset Oplog: Disabled
- NodeJS Version: 8.11.4 - x64
- MongoDB Version: v3.6.8
Additional context
Notifications_Max_Room_Members is set to 0, so that's not stopping @all.
All emails are verified.
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by posting a message with @all and checking the outgoing email count against the 262 users described. Trace the @all mention notification path and verify that all eligible, verified users receive an email when Notifications_Max_Room_Members is 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, nodejs, typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100