RocketChat / RocketChat/Rocket.Chat

Verification email has invalid From: header value of 'https:;'

Open
#13,499 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: email type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Just installed 0.74.3 server on Fedora-29 and have created some accounts. I went to validate my email address via "Resend Verification Email" and it failed sending to localhost:25. I got tcpdump up and can see why.

I have DKIM enabled on localhost and it rejects the email due to it having a From header of

From: https:;

Invalid - so the DKIM parser rejected it. I have configured the From header to be a legitimate address under /admin/Email - and the "TEst email" button there works correctly and I get the test email - but it looks like the Validator uses a different From: header - and that's not set?

Steps to reproduce:
  1. Resend Verification Email
  2. get error "Error trying to send email: Message failed"
  3. tcpdump shows the bad From header and the DKIM error that causes
Expected behavior:

legitimate formatted email is needed

Actual behavior:
Server Setup Information:
  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Additional context
Relevant logs:

/api/info == 0.74.3
Firefox

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Resend Verification Email flow and the email settings under /admin/Email, then compare its sender configuration with the working Test email path. Reproduce the failure and inspect the generated message; done means verification emails use the configured legitimate From address and are accepted by the local DKIM check.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.