RocketChat / RocketChat/Rocket.Chat
[IMPROVEMENT] Forbidden mention of @all/@here deletes message
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
If you mention @all or @here in a channel with more members than allowed for those mentions, there is just a bot message
Group mentions @all and @here have been disabled for rooms with more than X members.
The sent message is lost.
Maybe a check of the limit and an alert to force the user to change the message would be helpful. Or an issue on Rocket.Chat to just disable the mention but send the message anyway.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by tracing where messages containing @all or @here are validated against the room member limit, then confirm the intended behavior with maintainers because the issue proposes either warning the user or sending the message without the mention. Done should preserve the user's message or clearly prevent submission with an actionable alert.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100