RocketChat / RocketChat/Rocket.Chat

Rocketchat Google SSO Button doesnt fit googles branding guidlines

Open
#13,060 7 comments 0 reactions 1 assignee View on GitHub

@brunosquadros is already working on this.

Since Jan 4, 2019.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Tried to veryfy googles oauth screen today and get an intersting note about Branding guidelins. It seems thelayout of the sso button doesnt fit their guidelines anymore.

Here is what I've got

Google Sign-In BrandingThe Google sign-in button on your project's homepage URL is not compliant with the Google sign-in branding guidelines. Please update the Google sign-in button on your website according to Google sign-in branding guidelines.Thank you for your patience. Please reply back to this email after your project is in compliance with the requirements above.

https://developers.google.com/identity/branding-guidelines/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.