RocketChat / RocketChat/Rocket.Chat
Add Auto-Submitted: auto-generated header to email notifications
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Emails from Rocket Chat should include an Auto-Submitted email header
Steps to reproduce:
- Receive an email notification from Rocket Chat
- View the full list of email headers for that notification
- There is no Auto-Submitted header in the email.
Expected behavior:
In order to play nicely with email systems, it is best practice to set the following header:
Auto-Submitted: auto-generated as per RFC 3834.
Also RFC 5436.
This reduces the possibility of email loops and possibly even a denial of service on some email systems.
Actual behavior:
No email header is added.
Server Setup Information:
- Version of Rocket.Chat Server: 0.71.1
- Operating System: CentOS 7.6
- Deployment Method: tar
- Number of Running Instances: 2
- DB Replicaset Oplog: enabled
- NodeJS Version: 8.9.3
- MongoDB Version: 3.0.15
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Rocket.Chat's email notification generation and the code that assembles outgoing email headers. Confirm the expected RFC 3834 value, then verify that a received notification includes Auto-Submitted: auto-generated and that the existing notification behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100