RocketChat / RocketChat/Rocket.Chat

Pidgin Plugin Users Receive Direct Messages from All Public Chat Channels

Open
#12,917 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: integration / plugin
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Note: this may not be an issue that needs to be fixed server side, but I'll post this here in case it is.

Our users on Pidgin began receiving messages from all public chat channels as direct messages (regardless of whether they're in those chat channels) once our RocketChat server snap updated from 71.1 to 72.1.

This bug only began after our on-site RocketChat server snap did an auto-refresh last night and updated our RocketChat server from 71.1 to 72.1

Our Pidgin users go here to get what they need to connect Pidgin to our RocketChat server
https://bitbucket.org/EionRobb/purple-rocketchat

From recent changes to purple-rocketchat, it appears Eion Robb is making changes to address something along these lines.
https://bitbucket.org/EionRobb/purple-rocketchat/commits/all
Commit 49c1775 "Further tweaks to the unknown channels"
Commit 8c4cb9c "Fix for messages from unknown channels appearing as one-to-one IM's"

Steps to reproduce:
  1. Start with a RocketChat server running v71.1
  2. Have a user on the Pidgin client (with purple-rocketchat) log into chat.
  3. Have a second user log into chat through their web browser, create a public channel, and send a message out into that channel. Check to see if the user on Pidgin saw that message show up as a direct message.
  4. Update the RocketChat server to 72.1 and repeat steps two and three.
Expected behavior:

Pidgin users should not receive messages from channels they are not members of. Pidgin users should not receive messages, that were sent to a chat channel, as direct messages from the person who sent them.

Actual behavior:

Pidgin users receive messages sent out in any public channel (regardless of whether they are in that channel) as a direct message from the user that sent them. Note: Pidgin users are not seeing this bug with messages sent out in private channels.

Server Setup Information:
  • Version of Rocket.Chat Server: 72.1
  • Operating System: Ubuntu 18.04, 64-bit, 4.15.0-39-generic
  • Deployment Method: Snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 8.11.3
  • MongoDB Version:
Additional context

This bug only began after our on-site RocketChat server snap did an auto-refresh last night and updated our RocketChat server from 71.1 to 72.1

Our Pidgin users go here to get what they need to connect Pidgin to our RocketChat server
https://bitbucket.org/EionRobb/purple-rocketchat

From recent changes to purple-rocketchat, it appears Eion Robb is making changes to address something along these lines.
https://bitbucket.org/EionRobb/purple-rocketchat/commits/all
Commit 49c1775 "Further tweaks to the unknown channels"
Commit 8c4cb9c "Fix for messages from unknown channels appearing as one-to-one IM's"

Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing Rocket.Chat server changes between versions 71.1 and 72.1 related to public-channel message delivery and the Pidgin integration. Review the linked purple-rocketchat commits for the expected handling of unknown channels, then reproduce the behavior using the listed steps. Done means public-channel messages are not delivered to non-members or presented as direct messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.