RocketChat / RocketChat/Rocket.Chat
Login Expiration and Forget User Session settings require server restart
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Our internal users reported having to log back into their desktop RocketChat clients when they returned to work each morning. Some of our users lock their workstations at night while others actually log out of or shutdown their workstations each night. The issue was reported in all cases.
In the RocketChat Server admin GUI, changes to "Login Expiration in Days" and/or "Forget User Session on Window Close" don't seem to take effect until the admin manually restarts the RocketChat server service.
RocketChat Server Version: 0.71.1
Server OS: Ubuntu 18.04
Desktop Client Version: 2.14.4 (Electron client)
Desktop OS: Win 10 LTSB 64-bit (build 14393).
Steps to reproduce:
- In the Accounts section of the server admin console, change the number of days for "Login Expiration in Days" to 1.
- Save the changes and then restart the RocketChat server service.
- Log into the server with the desktop RockeChat client (2.14.1 - 2.14.4) and check it in ~24 hours to see if it's still logged into the server.
- In the Accounts section of the server admin console, change the number of days for "Login Expiration in Days" to 90.
- Save the changes but DO NOT RESTART the RocketChat server service.
- Log into the server with the desktop RockeChat client (2.14.1 - 2.14.4) and check it in ~24 hours to see if it's still logged into the server.
Repeat similar steps with the "Forget User Session on Window Close" setting (I think you don't need to wait 24 hours for this test but do try quitting the desktop RocketChat client and reopening it to see if the user is still logged into chat).
(Note: some of our users lock their workstations at night while others actually log out of their workstations each night. In both cases, users reported having to log back into their desktop RocketChat clients the next morning when they returned to work)
Expected behavior:
If restarting the RocketChat server service isn't required to apply changes to these settings, then they should work after being saved by the admin.
Actual behavior:
It appears that changes to these settings require restarting the RocketChat server service.
Server Setup Information:
- Version of Rocket.Chat Server: 0.71.1
- Operating System: Ubuntu 18.04 (64 bit, 4.4.0-137-generic)
- Deployment Method: Snap
- Number of Running Instances: 1
- DB Replicaset Oplog: Enabled
- NodeJS Version: 8.11.3
- MongoDB Version:
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Accounts settings changes on Rocket.Chat Server 0.71.1, comparing behavior after saving with and without a server restart. Check both “Login Expiration in Days” and “Forget User Session on Window Close” using the listed desktop client versions. Done means both settings take effect after being saved without restarting the server.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, mongodb, node.js
- Domain
- authentication, backend, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100