RocketChat / RocketChat/Rocket.Chat

LDAP sync user email : imported as Buffer, cause error during sync

Open
#12,565 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

area: authentication
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Error when LDAP sync for new user. Email seems to be imported as Buffer object not as string when importing from LDAP record.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.71.1 (already since 0.69.3)
  • Operating System: Centos 7.5
  • Deployment Method: tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 8.11.3
  • MongoDB Version: 2.6.12
Relevant logs:

debug New user data { username: 'yyyyy', email: <Buffer xx xx xx ...> }
I20181108-14:32:50.238(1) rocketchat_logger rocketchat_logger.js:278 LDAPSync ➔ error Error creating user { Error: Match error: Expected string, got object in field email at check (/opt/Rocket.Chat/programs/server/packages/check.js:68:17) at createUser (/opt/Rocket.Chat/programs/server/packages/accounts-password.js:1215:3) at AccountsServer.Accounts.createUser (/opt/Rocket.Chat/programs/server/packages/accounts-password.js:1302:10) at addLdapUser (/opt/Rocket.Chat/programs/server/packages/rocketchat_ldap.js:1290:31)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.