RocketChat / RocketChat/Rocket.Chat

i18n /api/apps/languages not always returning all results

Open
#12,438 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: backend type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

This is incredibly hard to reproduce... I did it one time and accidentally overwrote my clipboard with the screenshot of it happening!

Essentially, typing / shows a list of available slash commands. While in the ?layout=embedded view, I typed / and saw a broken list of slash commands. It shows things like app description, then a GUID instead of examples of what to type. I've spent the last 20 minutes trying to reproduce it, but I have not been able to.

Steps to reproduce:
  1. Open a direct message in /direct/username?layout=embedded
  2. Type /
Expected behavior:

image

Actual behavior:

In rare cases it doesn't actually show the slash command information, instead, it shows GUIDs for the apps. I wasn't able to get a screenshot -- I will update this issue if it happens again.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.70.4 dbff6ee20ff756d5654bc36da66de4999ff7cd9c
  • Operating System: Centos 7
  • Deployment Method: tar zxvf , npm install, service start.
  • Number of Running Instances: 1
  • NodeJS Version: v8.9.3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the /api/apps/languages entry point and trace how its results populate slash commands in the embedded direct-message view. Exercise the /direct/username?layout=embedded flow while typing /, then verify that every app shows its command information rather than a GUID and add coverage for the intermittent response if the relevant test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, internationalization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.