RocketChat / RocketChat/Rocket.Chat
LDAP: Update fallback description - inform about password sync
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description
Setting -> LDAP -> Login Fallback
The setting-description says:
If the login on LDAP is not successful try to login in default/local account system. Helps when the LDAP is down for some reason.
Expected behavior: In case the user has a local account, the user is able to login in case the LDAP is down.
Actual behavior: By enabling Fallback, the LDAP password is copied into the local DB no matter what.
Solution: change description to "By enabling Fallback, LDAP Users will be stored as local Users in the DB. This includes the encrypted password. If the login on LDAP is not successful try to login in default/local account system. Helps when the LDAP is down for some reason. Disabling this feature does not remove the stored password.
Additional issue: Disabling this feature does not remove the stored password. This should probably discussed separately since this could be a security issue in case the encryption breaks or the feature is enabled by accident.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.