RocketChat / RocketChat/Rocket.Chat
[BUG] Realtime API: subscriptions-changed does not include room ID when a room is left
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
In the stream-notify-user, the subscriptions-changed event received when a room is left does not tell which room was left
Steps to reproduce:
- Connect to Realtime API, log in, subscribe to
stream-notify-user - Add user to a room
- Remove user from a room
Expected behavior:
I receive an event via the Realtime API telling that the user was removed from a room, and which room.
Actual behavior:
Event without information about WHICH room was left.
Server Setup Information:
- Version of Rocket.Chat Server: latest devel
- Operating System: MacOS
- Deployment Method: NPM
- Number of Running Instances: 1
- DB Replicaset Oplog: n/a
- NodeJS Version: v10.10.0
- MongoDB Version: n/a
Additional context
A fix has been submitted at #12078
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Realtime API's stream-notify-user and subscriptions-changed event handling, then inspect the fix referenced in #12078. Confirm that the event emitted after a room is left identifies which room was left, and verify the existing reproduction steps against that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100