RocketChat / RocketChat/Rocket.Chat

Room info retention policy banner does not take exclude pinned messages and only delete files into account in its message.

Open
#12,182 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When the retention policy for messages are activated, and the option "Only delete files" is selected,
the message at top of channels are correctly showing:

Unpinned files older than 30 days are automatically pruned here (messages stay intact)

However, the retention policy message shown on the group info page, shows:

Messages older than 30 days are automatically pruned here

Steps to reproduce:
  1. Go to Administration -> Retention Policy and activate retention policy.
  2. In the global policy section, set "True for "applies to ..." for channels, private groups and direct messages, and select 30 days retention policy.
  3. Set "True" for "Exclude pinned messages"
  4. Set "True" for "Only delete files"
  5. Go to a private group and scroll to the top of the messages to view the message. It will read "Unpinned files older than 30 days are automatically pruned here (messages stay intact)"
  6. Go to the same private group and click the group info page. The retention message will read
    "Messages older than 30 days are automatically pruned here"
Expected behavior:

The expectation is that the retention policy message/notice should be the same at the top of the message history and on the group/channel info page.

Actual behavior:

The retention policy message/notice on the group/channel info age does not take "exclude pinned messages" and "only delete files" into account when displaying the message.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.69.2
  • Operating System: Linux
  • Deployment Method: docker
  • Number of Running Instances: 2
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v8.11.3
  • MongoDB Version: "latest version provided by docker deployment at (Sep 27, 2018)"
Additional context

N/A

Relevant logs:

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the group info page and compare its retention-policy notice with the message shown at the top of the message history. Reproduce the configuration using “Exclude pinned messages” and “Only delete files” with a 30-day policy. Done means both notices describe the same retention behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.