RocketChat / RocketChat/Rocket.Chat
"UI_Allow_room_names_with_special_chars" does not translate back to fname in global search and server directory
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When the option "UI_Allow_room_names_with_special_chars" is set to true, Rocket.Chat should pick up the channel/room name based on the fname database attribute rather than the name one.
Currently it looks like this doesn't happen in the global search and the channel/room directory:
Server Setup Information:
- Version of Rocket.Chat Server: 0.65.1
- Operating System: Ubuntu
- Deployment Method(snap/docker/tar/etc): Docker
- Number of Running Instances: 1
- DB Replicaset Oplog: yes
- Node Version: official Docker container
- mongoDB Version: official Docker container
Steps to Reproduce:
- Setup new RC instance
- Make sure
UI_Allow_room_names_with_special_charsis set totrue(Admin -> Layout -> UI) - Create a new room/channel with special UTF8 characters (chinese ones, for example:
一)
Expected behavior:
Special (UTF8) characters (fname attribute) should visible in the global search and channel directory.
Actual behavior:
Special character missing in global search and channel directory (name attribute is shown rather than fname).
Global search
Channel directory
Relevant logs:
Relevant Mongo entry:
{ "_id" : "3YhymvLzujPrs9Ngy", "name" : "test", "fname" : "一test", "t" : "c", "msgs" : 0, "usernames" : [ "frdmn" ], "u" : { "_id" : "929N8ZdxGDk5Xi6Ed", "username" : "frdmn" }, "customFields" : { }, "broadcast" : false, "ts" : ISODate("2018-06-04T11:45:59.811Z"), "ro" : false, "sysMes" : true, "_updatedAt" : ISODate("2018-06-04T11:45:59.811Z") }
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the global search and channel directory entry points, tracing how each displays room data; the issue provides a MongoDB record containing both name and fname. Done when rooms with special UTF-8 characters display fname in both locations while ordinary room names continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb
- Domain
- frontend, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100