RocketChat / RocketChat/Rocket.Chat
[BUG] No link preview is shown if at least one of the links is invalid
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When there are multiple links in a message, each one of them has a preview, however if at least one of the links is invalid, the other valid links do not have a preview.
Server Setup Information:
- Version of Rocket.Chat Server: 0.64.0-develop
- Operating System: Elementary OS 0.4.1 (Ubuntu 16.04 based)
- Deployment Method(snap/docker/tar/etc): Development
- Number of Running Instances: 1
- DB Replicaset Oplog:
- Node Version: 8.11.1
- mongoDB Version: 3.4.10
Steps to Reproduce:
- Send a message with 2 or more valid links
- Send a message with 2 or more links, at least one invalid
Expected behavior:
On 1, the preview of all links should be exhibited. On 2, the preview of all valid links should be exhibited.
Actual behavior:
On 1, works fine. On 2, no preview is shown.
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the two-link cases in a local Rocket.Chat development instance, comparing all-valid links with a mix of valid and invalid links. Trace the link-preview handling from the message flow; done means valid links still display previews when another link fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100