RocketChat / RocketChat/Rocket.Chat

[BUG] Opening a hidden channel/dm throws exception and does not show on sidebar

Open
#10,723 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When you open a room that is hidden, two exceptions are thrown: Exception in queued task: Error: Can't set timers inside simulations and Exception in queued task: Error: Unknown id for changed: <roomId>

Server Setup Information:
  • Version of Rocket.Chat Server: 0.64.0 (reproducible on open.rocket.chat)
  • Operating System: Elementary OS
  • Deployment Method(snap/docker/tar/etc): Development
  • Number of Running Instances: 1
  • Node Version: v8.11.1
Steps to Reproduce:
  1. Open the browser's dev console
  2. Hide any channel or DM
  3. Go to the sideNav search and try to open the hidden channel or DM.
Expected behavior:
  1. A clean console
  2. Room open (check)
  3. Opened room being listed in the sideNav
Actual behavior:
  1. Two exceptions thrown are logged into the console
  2. Room open (check)
  3. Opened room not listed in the sideNav

Note: This behavior isn't consistent, sometimes it works, sometimes it does not.

Bonus bug:

If there are no current opens in a room section (example, no channels opened and "You are not part of any channel" displaying), when you open a hidden channel, the message is gone because there is a room now but it crashes before displaying.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the sideNav search flow that opens hidden channels or DMs, using the browser console to reproduce both reported exceptions. Trace why the opened room is not added to the sidebar, including the empty-room-section case; done means the room appears in the sideNav and opening it leaves a clean console.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.