RocketChat / RocketChat/Rocket.Chat
Validate "Site_URL" in backend
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Rocket.Chat has a Site URL setting called Site_url. This setting is used to render absolut paths. However, if the site URLs ends with a slash / , pictures are not displayed in the iOS app. Please see issue https://github.com/RocketChat/Rocket.Chat.iOS/issues/1646 for details. Because of this, the backend should check, if a slash at the end is present. If yes, it should handle it.
Server Setup Information:
- Version of Rocket.Chat Server: 0.63.3
Steps to Reproduce:
- Add a slash at the end of the site url, e.g.
https://example.com/ - Upload a picture into a channel
- The picture is not displayed in iOS
Expected behavior:
Backend handles slash (removing it when necessary).
Actual behavior:
No handling in place
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the backend handling for the Site_URL/Site_url setting and reproduce the issue with a trailing slash, then upload a channel picture as described. Done means the backend handles the trailing slash correctly and the picture is displayed in the iOS app.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100