RocketChat / RocketChat/Rocket.Chat

Inactive Account Emails Are Hardcoded

Open
#10,264 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: improvement
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When a user is created as inactive they are sent an email by Rocket.Chat.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.62.2
  • Operating System: Ubuntu Xenail
  • Deployment Method(snap/docker/tar/etc): Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Yes
  • Node Version: 8.9.4
  • mongoDB Version: 3.4
Steps to Reproduce:
  1. Create a user via REST API that is set to inactive
  2. Check your email, you have an unsolicited email that is not controllable, templateable, or cannot be disabled.
Expected behavior:

There is an option to send an email to this effect or not (much like very other email out of Rocket.Chat) and a template for what should be sent.

Actual behavior:

It unilaterally decides to send this hard-coded, poorly formatted email that is very confusing to customers/users and that cannot be disabled.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior through the REST API as described in the issue, then trace the inactive-user creation flow and the email it sends. Done means the email can be disabled, customized through a template, and is no longer sent unconditionally; the issue does not name a file or test to run.

Written by the indexing model from the issue text.

Assessment

Domain
api, authentication, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.