RocketChat / RocketChat/Rocket.Chat
BUG: users with a space in the name cannot be at-mentioned
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
We allow the use of social logins. Users may come in from GitHub, or Google+, for instance and put a space in the username when they sign up. I am unable to at-mention these users.
Server Setup Information:
- Version of Rocket.Chat Server: 3.4.2
Steps to Reproduce:
- create user with space in name
- join user to channel
- attempt to at-mention user
- User appears in pick list, is chosen
Expected behavior:
- alert is sent to user with space in name
Actual behavior:
- no alert is sent
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failed at-mention with a username containing a space, then trace the mention handling and notification path from the channel message flow. Check how the selected user is identified and notified. Done means the user receives the alert and the existing behavior remains intact for usernames without spaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100