RocketChat / RocketChat/Rocket.Chat

Push notifications are being sent to deactivated users

Open
#10,244 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: notification type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

We had an employee notify us that they were still receiving push notifications on their mobile device from our RocketChat installation. This was surprising to us because their RocketChat account had been deactivated. I tested this in our staging environment and was able to reproduce the issue.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.62.1
  • Operating System: Ubuntu 16.04
  • Deployment Method(snap/docker/tar/etc): TAR
  • Number of Running Instances: 3
  • DB Replicaset Oplog: Enabled
  • Node Version: 8.9.4
  • mongoDB Version: 3.4.13
Steps to Reproduce:
  1. Create a secondary RocketChat account.
  2. Login using the secondary account on the RocketChat mobile app. I tested this on Android.
  3. Mention the secondary user in a room (using the @user syntax).
  4. Deactivate the secondary account from the administrative panel.
  5. Mention the secondary user in a room again.
Expected behavior:

Mobile device does not receive a push notification.

Actual behavior:

Mobile device does receive a push notification. Upon clicking on the notification, a login screen is shown (which is expected) and no further push notifications are received.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reproducing the deactivated-account scenario described in the issue, then trace the push-notification path and its account-status checks. Done means a deactivated user receives no push notification when mentioned, while active users continue to receive notifications.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, typescript
Domain
backend, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.