RocketChat / RocketChat/Rocket.Chat
Create channels, but can't display full chinese text error
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Rocket.Chat version: (snap 0.62.1)
Client version: Rocker.Chat+2.10.5
When I want to create a channel, inputting Chinese through the Chinese input method will display all the Chinese character roots. In fact, after all the roots are determined, the last Chinese character will be displayed. This problem only occurs in the channel text field of the generated channel. With user name text field.
E.g
Channel Name: "ㄓㄨㄥㄨㄣ"
Chinese Pinyin (ㄓㄨㄥ -> 中) , (ㄨㄣ->文)
Correct should be
Channel Name: "中文"
I try to modify the code below and solve the problem
Rocket.Chat/packages/rocketchat-ui/client/views/app/createChannel.js line 169 & 180
/*input.value = modified;*/
if ( input.value != modified ) {input.value = modified}
I believe this problem exists in the Japanese input method or the Korean input method. Expect the next version to be corrected.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/rocketchat-ui/client/views/app/createChannel.js around lines 169 and 180, then reproduce channel creation with a Chinese input method. Compare the channel-name field with the user-name field and verify that composed Chinese text is displayed as completed characters rather than input-method roots. Check the corresponding Japanese and Korean input-method behavior if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100